-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scheduling op to helm chart #697
Add scheduling op to helm chart #697
Conversation
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
7212a7f
to
474b8cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small nit, overall looks good to me.
manifests/install/charts/as-a-second-scheduler/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
474b8cb
to
54876a2
Compare
/lgtm |
/assign @Huang-Wei |
Could you add a release note in the PR's description? (in the /lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, mochizuki875 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Huang-Wei |
PTAL? |
ah I suppose you'd have cancelled the /hold youself. /unhold |
/retest |
@mochizuki875 could you rebase the PR? (although there is no conflict) The CI failure is related setup-envtest, which should go away after rebasing. |
54876a2
to
a8e31a2
Compare
a8e31a2
to
e68bde0
Compare
You're right, I had a bad memory... I encountered this issue in my another project and commented here. I thought I fixed in this repo but I didn't... Thanks a lot for the fix! |
hack/install-envtest.sh
Outdated
@@ -32,6 +32,6 @@ version=$(cat ${SCRIPT_ROOT}/go.mod | grep 'k8s.io/kubernetes' | grep -v '=>' | | |||
|
|||
GOPATH=$(go env GOPATH) | |||
TEMP_DIR=${TMPDIR-/tmp} | |||
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest | |||
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change to 0.15 to align with go.mod:
Line 31 in cd3e4fb
sigs.k8s.io/controller-runtime v0.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've fixed it.
e68bde0
to
70c77ce
Compare
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add ability to change
nodeSelector
,affinity
andtolerations
of Pods installed via Helm Chart.Which issue(s) this PR fixes:
Fixes #696
Special notes for your reviewer:
Does this PR introduce a user-facing change?