Add ARG for base image customization

[jgu17]

Add ARG to define the base image parameters so a downstream pipeline can override which the base golang image to use when building container images.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jgu17 (4a00cfd)

[k8s-ci-robot]

Welcome @jgu17!

It looks like this is your first PR to kubernetes-sigs/scheduler-plugins 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/scheduler-plugins has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jgu17. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name	Link
🔨 Latest commit	4a00cfd
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66455d64e0165b000866350d

[Huang-Wei]

Thanks for the contribution @jgu17 . Could you sign the CLA?

[Huang-Wei]

/ok-to-test

[jgu17]

Thanks for the contribution @jgu17 . Could you sign the CLA?

Done

[jgu17]

/release-note-none

[Huang-Wei]

could you keep it consistent to use /t instead of spaces here? (Makefile sometimes is strict on using tabs.

[jgu17]

Good catch. Copy and paste in the vi editor changed the /t to spaces. Fixed.

[Huang-Wei]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, jgu17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Huang-Wei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jgu17]

@Huang-Wei Appreciate the approval! Do you know if there is a schedule for the next release? We would like to be able to build an image based on release tag using customized base images as soon as possible. What would you suggest, is there a hot fix process to port it back to the last release for example, if the new release schedule is still tbd?

[Huang-Wei]

The next release is usually current release + 3 months.

We would like to be able to build an image based on release tag using customized base images as soon as possible.

for which release, and which base image? and may I know the reason?

What would you suggest, is there a hot fix process to port it back to the last release for example

It will depend on the severity of the thing we need to fix. Could you elaborate on your use case?

[Huang-Wei]

Actually post each PR's merge, there are jobs running image building: https://testgrid.k8s.io/sig-scheduling#post-scheduler-plugins-push-images. For example, the build image based latest master commit is: gcr.io/k8s-staging-scheduler-plugins/kube-scheduler@sha256:6992147099ab0208aac1581d10c3c76ac51a85ebeca1da9d1c4d86ed14278024

[jgu17]

The next release is usually current release + 3 months.

We would like to be able to build an image based on release tag using customized base images as soon as possible.

for which release, and which base image? and may I know the reason?

What would you suggest, is there a hot fix process to port it back to the last release for example

It will depend on the severity of the thing we need to fix. Could you elaborate on your use case?

We used to have a forked downstream repo for scheduler-plugins and we would like to eliminate the forked repo, and contribute to and consume directly from the k8s-sig project. We are creating downstream pipelines that build container images from a mirrored repo from this scheduler-plugins repo and needs to overwrite the default base images in the Docker files with base images from a different registry that has additional built-in security mechanism and/or different linux distro. The pipeline is triggered by release tags in the upstream scheduler-plugins repo. The first build will be based off the last upstream release 0.28.9.

[Huang-Wei]

Gotcha. Do you need me to port this back to release-1.28 and then cut a new tag?

[jgu17]

That would be much appreciated. I can cherry pick this PR over if you want me to. The branch name 1.28 vs tag name 0.28.9 threw me off so I didn't know where to cherry pick to. But we will soon submit a CVE PR related to OTEL library first before asking to cut a new tag, if you don't mind.

[Huang-Wei]

I can cherry pick this PR over if you want me to.

Prow can do this, we just:

/cherrypick release-1.28

But we will soon submit a CVE PR related to OTEL library first before asking to cut a new tag, if you don't mind.

SGTM. Check if the PR is needed on master first, if yes, submit to master and cherrypick later; otherwise, submit a PR to branch release-1.28.

[k8s-infra-cherrypick-robot]

@Huang-Wei: new pull request created: #740

In response to this:

I can cherry pick this PR over if you want me to.

Prow can do this, we just:

/cherrypick release-1.28

But we will soon submit a CVE PR related to OTEL library first before asking to cut a new tag, if you don't mind.

SGTM. Check if the PR is needed on master first, if yes, submit to master and cherrypick later; otherwise, submit a PR to branch release-1.28.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.