-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVE-2023-47108 in go.opentelemetry.io #742
Conversation
|
Hi @jgu17. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
/ok-to-test |
@jgu17 please append a commit w/ all |
Sounds good, included the changes from go mod vendor. @Huang-Wei |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, jgu17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.28 |
@Huang-Wei: #742 failed to apply on top of branch "release-1.28":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick release-1.28 |
@jgu17: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Huang-Wei Many thanks for reviewing. Could I ask another favor to cherry pick to 1.28? it doesn't look I have earned the permission to do so yet :-) |
This PR cannot be automatically cherrypicked (due to |
@jgu17 it seems the go.mod changes for master is incompatible w/ release-1.28. Could you raise a PR to release-1.28 to manually resolves the dependency issue? |
will do |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix CVE-2023-47108 in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.42.0
Which issue(s) this PR fixes:
Fixes #741
Special notes for your reviewer:
Does this PR introduce a user-facing change?