Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove vendoring from this repo #761

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdtuhui
Copy link

@jdtuhui jdtuhui commented Jun 20, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove vendor folder, Use go.mod to download dependent code

Which issue(s) this PR fixes:

Fixes #
#760

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 20, 2024
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @jdtuhui!

It looks like this is your first PR to kubernetes-sigs/scheduler-plugins 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/scheduler-plugins has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jdtuhui. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit d071045
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66743d0d6fa1e000084deea9

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jdtuhui
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes
Copy link

jaypipes commented Jul 3, 2024

@Huang-Wei @zwpaper thoughts on this PR? :)

@googs1025
Copy link
Member

@jdtuhui we should fix EasyCLA first.
Also, I think this is not a kind bug classification, but a cleanup classification, please let me know if I am wrong.

@googs1025
Copy link
Member

/remove-kind bug
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 3, 2024
@googs1025
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

@jdtuhui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-scheduler-plugins-unit-test-master d071045 link true /test pull-scheduler-plugins-unit-test-master
pull-scheduler-plugins-integration-test-master d071045 link true /test pull-scheduler-plugins-integration-test-master
pull-scheduler-plugins-verify d071045 link true /test pull-scheduler-plugins-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Huang-Wei
Copy link
Contributor

We used to add vendor/ intentionally b/c of some code (zz_openapi*.go) are excluded in git, but needed to make codegen functional. So it ends up developer having to locally install necessary toolkit to do codegen, which is quite cumbersome.

But due to recent refactoring on codegen scripts (both this repo and upstream), those zz_openapi*.go might not be needed, and hence we can get rid of the whole vendor/ folder.

cc @zwpaper @denkensk @ffromani

@ffromani
Copy link
Contributor

We used to add vendor/ intentionally b/c of some code (zz_openapi*.go) are excluded in git, but needed to make codegen functional. So it ends up developer having to locally install necessary toolkit to do codegen, which is quite cumbersome.

But due to recent refactoring on codegen scripts (both this repo and upstream), those zz_openapi*.go might not be needed, and hence we can get rid of the whole vendor/ folder.

cc @zwpaper @denkensk @ffromani

I for myself I don't have strong opinions on the matter. If there is user demand to remove vendor/ and we have options projectwise to do so, then why not?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zwpaper
Copy link
Member

zwpaper commented Jul 26, 2024

I would prefer dropping the vendor/ dir if we do not need it for codegen anymore, that would reduce unnecessary changes for PRs, and we can focus more on our core logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants