-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove vendoring from this repo #761
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @jdtuhui! |
Hi @jdtuhui. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jdtuhui The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Huang-Wei @zwpaper thoughts on this PR? :) |
@jdtuhui we should fix |
/remove-kind bug |
/ok-to-test |
@jdtuhui: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We used to add But due to recent refactoring on codegen scripts (both this repo and upstream), those zz_openapi*.go might not be needed, and hence we can get rid of the whole vendor/ folder. |
I for myself I don't have strong opinions on the matter. If there is user demand to remove |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I would prefer dropping the |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Remove vendor folder, Use go.mod to download dependent code
Which issue(s) this PR fixes:
Fixes #
#760
Special notes for your reviewer:
Does this PR introduce a user-facing change?