-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying the scheduler container entrypoint in the helm chart #814
Conversation
Welcome @chotiwat! |
Hi @chotiwat. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
By "older kube-scheduler image", do you mean the v0.29.7 image? If so, we changed back the default entrypoint to /bin/scheduler (#794) - which is available in v0.29.8 and master. And we will keep the path unchanged in the future, for backwards compatibility. Did it resolve your issue? xref: https://kubernetes.slack.com/archives/C09TP78DV/p1723546975114219 |
@Huang-Wei By older images, I mean the ones before v0.29, e.g. https://github.com/kubernetes-sigs/scheduler-plugins/blob/v0.27.9/build/scheduler/Dockerfile#L28. I'd like to use the latest chart with an older image version to match my org's k8s clusters. |
ok, I see the motiviation. /ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chotiwat, Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The current chart template doesn't support the older kube-scheduler image which doesn't specify ENTRYPOINT in the image. This PR allows customizing the container entrypoint through the new
scheduler.command
value.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?