feat: add default toleration for all taints

ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration - An empty `key` with operator `Exists` matches all keys, values and effects which means this will tolerate everything. Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
kubernetes-sigs · Dec 8, 2022 · b4d2608 · b4d2608
1 parent 8a38583
commit b4d2608
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/manifest_staging/charts/secrets-store-csi-driver/README.md b/manifest_staging/charts/secrets-store-csi-driver/README.md
@@ -47,7 +47,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
 | `linux.providersDir`                    | Configure the providers root dir                                                                                                                                               | `/var/run/secrets-store-csi-providers`                  |
 | `linux.additionalProvidersDirs`         | List of additional paths to communicate with providers. Refer to [issue](https://github.com/kubernetes-sigs/secrets-store-csi-driver/issues/823) for more details.             | `[/etc/kubernetes/secrets-store-csi-providers]`         |
 | `linux.nodeSelector`                    | Node Selector for the daemonset on linux nodes                                                                                                                                 | `{}`                                                    |
-| `linux.tolerations`                     | Tolerations for the daemonset on linux nodes                                                                                                                                   | `[]`                                                    |
+| `linux.tolerations`                     | Tolerations for the daemonset on linux nodes                                                                                                                                   | `[{"operator": "Exists"}]`                              |
 | `linux.metricsAddr`                     | The address the metric endpoint binds to                                                                                                                                       | `:8095`                                                 |
 | `linux.registrarImage.repository`       | Linux node-driver-registrar image repository                                                                                                                                   | `registry.k8s.io/sig-storage/csi-node-driver-registrar` |
 | `linux.registrarImage.pullPolicy`       | Linux node-driver-registrar image pull policy                                                                                                                                  | `IfNotPresent`                                          |
@@ -77,7 +77,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
 | `windows.providersDir`                  | Configure the providers root dir                                                                                                                                               | `C:\k\secrets-store-csi-providers`                      |
 | `windows.additionalProvidersDirs`       | List of additional paths to communicate with providers. Refer to [issue](https://github.com/kubernetes-sigs/secrets-store-csi-driver/issues/823) for more details.             | `[]`                                                    |
 | `windows.nodeSelector`                  | Node Selector for the daemonset on windows nodes                                                                                                                               | `{}`                                                    |
-| `windows.tolerations`                   | Tolerations for the daemonset on windows nodes                                                                                                                                 | `[]`                                                    |
+| `windows.tolerations`                   | Tolerations for the daemonset on windows nodes                                                                                                                                 | `[{"operator": "Exists"}]`                              |
 | `windows.metricsAddr`                   | The address the metric endpoint binds to                                                                                                                                       | `:8095`                                                 |
 | `windows.registrarImage.repository`     | Windows node-driver-registrar image repository                                                                                                                                 | `registry.k8s.io/sig-storage/csi-node-driver-registrar` |
 | `windows.registrarImage.pullPolicy`     | Windows node-driver-registrar image pull policy                                                                                                                                | `IfNotPresent`                                          |

diff --git a/manifest_staging/charts/secrets-store-csi-driver/values.yaml b/manifest_staging/charts/secrets-store-csi-driver/values.yaml
@@ -81,7 +81,10 @@ linux:
   additionalProvidersDirs:
     - /etc/kubernetes/secrets-store-csi-providers
   nodeSelector: {}
-  tolerations: []
+  # ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
+  # An empty key with operator Exists matches all keys, values and effects which means this will tolerate everything.
+  tolerations:
+    - operator: "Exists"
   metricsAddr: ":8095"
   env: []
   priorityClassName: ""
@@ -165,7 +168,10 @@ windows:
   providersDir: C:\\k\\secrets-store-csi-providers
   additionalProvidersDirs:
   nodeSelector: {}
-  tolerations: []
+  # ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
+  # An empty key with operator Exists matches all keys, values and effects which means this will tolerate everything.
+  tolerations:
+    - operator: "Exists"
   metricsAddr: ":8095"
   env: []
   priorityClassName: ""

diff --git a/manifest_staging/deploy/secrets-store-csi-driver-windows.yaml b/manifest_staging/deploy/secrets-store-csi-driver-windows.yaml
@@ -127,5 +127,7 @@ spec:
           hostPath:
             path: C:\k\secrets-store-csi-providers\
             type: DirectoryOrCreate
+      tolerations:
+      - operator: Exists
       nodeSelector:
         kubernetes.io/os: windows
diff --git a/manifest_staging/deploy/secrets-store-csi-driver.yaml b/manifest_staging/deploy/secrets-store-csi-driver.yaml
@@ -137,5 +137,7 @@ spec:
           hostPath:
             path: /var/run/secrets-store-csi-providers
             type: DirectoryOrCreate
+      tolerations:
+      - operator: Exists
       nodeSelector:
         kubernetes.io/os: linux