-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate status subresource for SecretProviderClassPodStatus
#1301
Comments
/assign @mandreap |
@aramase: GitHub didn't allow me to assign the following users: mandreap. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
@aramase should we update the SecretProviderClass as well? |
yes, let's update it! |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
The
kubebuilder
annotations here:secrets-store-csi-driver/apis/v1/secretproviderclasspodstatus_types.go
Lines 43 to 49 in 57b18e8
is missing the
kubebuilder:subresource:status
bit, example:https://github.com/vmware-tanzu/pinniped/blob/0f613d1823d8eaa8a6cf3cb4a1d75d664be79a1e/apis/supervisor/config/v1alpha1/types_federationdomain.go.tmpl#L116
This means that the API server isn't creating the status sub resource for the CR, nor is it enforcing the rules between spec/status.
The fix would involve updating the annotations, RBAC, CRDs and then also doing an upgrade and downgrade check for the CR with "legacy" data. Probably also would need a release note that tells people not to try to mix and match old/new images with old/new manifests. In addition, we also need to update any
Create
calls that setStatus
and move allUpdate
calls toUpdateStatus
.The text was updated successfully, but these errors were encountered: