-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate toleration daemonset and crd upgrade hook #1538
base: main
Are you sure you want to change the base?
separate toleration daemonset and crd upgrade hook #1538
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
- Coverage 35.83% 35.71% -0.12%
==========================================
Files 63 63
Lines 3759 3757 -2
==========================================
- Hits 1347 1342 -5
- Misses 2268 2272 +4
+ Partials 144 143 -1 ☔ View full report in Codecov by Sentry. |
Hey @sstarcher any update on this one? |
for Linux nodes
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omerap12, sstarcher The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Adding option to separate out toleration for daemonset and crd upgrade hook.
The following values.yaml file:
Will generate the following manifests:
Added backward compatibility by defaulting to the linux.tolerations when no explicit tolerations are provided.
with the default values we get:
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1535
Special notes for your reviewer:
TODOs: