-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use controller to reconcile k8s secrets #224
Conversation
e45c81d
to
1b7b8bc
Compare
charts/secrets-store-csi-driver/templates/secrets-store.csi.x-k8s.io_secretproviderclasses.yaml
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-secrets-store-csi-driver-e2e-windows |
test/bats/azure.bats
Outdated
@@ -55,6 +55,7 @@ setup() { | |||
} | |||
|
|||
@test "CSI inline volume test" { | |||
skip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to skip these tests, should we just remove them? Then in a separate PR, remove all references of provider parameters from pod spec. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Removed it.
/wip |
/lgtm |
What this PR does / why we need it:
SecretProviderClassPodStatus
to track the status of the mount for the podSecretProviderClassPodStatus
is created with the pod asownerReference
SecretProviderClass
asownerReference
.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #188
Special notes for your reviewer:
Design doc: https://docs.google.com/document/d/1EM0Lf-qSdUXdfjOx3AZB9yHOr-lw9_CtoUhR0eTmIwo/edit?usp=sharing