-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: best-effort cleanup socket #387
Conversation
/retitle chore: best-effort cleanup socket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
a37ebe4
to
bec4f62
Compare
abbaa32
to
9b42564
Compare
Build a cancellable context and propagate it or the context's Done() channel to the various concurrent processes.
9b42564
to
693a233
Compare
After some trial and error I think this is back ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ritazh, tam7t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Cleanup missing
Close()
on the unix socket which can lead to the file persistent. This is best effort, if the process does not exist gracefully the socket file could remain.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #367
Special notes for your reviewer:
I think this is all that's missing unless I'm misunderstanding #367
The wait group on
NonBlockingGRPCServer
was never actually done. UpdatedStart
to pass in a parent cancelable context so thatStart
andWait
could finish.