chore: best-effort cleanup socket #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/retitle chore: best-effort cleanup socket |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
lgtm
tam7t
force-pushed
the
csi-socket-cleanup
branch
from
a37ebe4
to
bec4f62
Compare
k8s-ci-robot
added
size/M
tam7t
force-pushed
the
csi-socket-cleanup
branch
3 times, most recently
from
abbaa32
to
9b42564
Compare
Build a cancellable context and propagate it or the context's Done() channel to the various concurrent processes.
tam7t
force-pushed
the
csi-socket-cleanup
branch
from
9b42564
to
693a233
Compare
|
After some trial and error I think this is back ready for review! |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ritazh, tam7t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cleanup missing
Close()on the unix socket which can lead to the file persistent. This is best effort, if the process does not exist gracefully the socket file could remain.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #367
Special notes for your reviewer:
I think this is all that's missing unless I'm misunderstanding #367
The wait group on
NonBlockingGRPCServerwas never actually done. UpdatedStartto pass in a parent cancelable context so thatStartandWaitcould finish.