Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update klog to v2.5.0 #449

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 11, 2021

What this PR does / why we need it:

  • Updates klog to v2.5.0 that contains a fix for missing fields in json format when structured logging is enabled.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
fixes #442
fixes Azure/secrets-store-csi-driver-provider-azure#387

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2021
@aramase aramase added this to the v0.0.20 milestone Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 11, 2021

@aramase: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-secrets-store-csi-driver-image-scan 18bd163 link /test pull-secrets-store-csi-driver-image-scan

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierluigilenoci
Copy link
Contributor

Thank you!

@tam7t
Copy link
Contributor

tam7t commented Feb 11, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7035879 into kubernetes-sigs:master Feb 11, 2021
@aramase aramase deleted the fix-klog branch February 11, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with log configurations Problems with log configurations
4 participants