fix: validate additionalProviderPaths does not contain providers dir

[paulczar]

Signed-off-by: Paul Czarkowski username.taken@gmail.com

What this PR does / why we need it:

Checks if additionalProviderPaths matches providerPaths to avoid duplicate volume mounts,

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #897

[k8s-ci-robot]

Hi @paulczar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nilekhc]

/ok-to-test

[aramase]

@paulczar thank you for the PR!

1. Could we also add the same check for volumes:
   

   secrets-store-csi-driver/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml

   Lines 183 to 192 in 9f0e46a

   	- name: providers-dir
   	hostPath:
   	path: {{ .Values.linux.providersDir }}
   	type: DirectoryOrCreate
   	{{- range $i, $path := .Values.linux.additionalProvidersDirs }}
   	- name: providers-dir-{{ $i }}
   	hostPath:
   	path: "{{ $path }}"
   	type: DirectoryOrCreate
   	{{- end }}

2. The windows template as well: https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml#L183

[paulczar]

@aramase good catch! hopefully this fixes both comments.

[k8s-ci-robot]

@paulczar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-secrets-store-csi-driver-image-scan	8bcfcc6	link	false	/test pull-secrets-store-csi-driver-image-scan

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[aramase]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, paulczar, smirman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aramase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aramase]

Ignore pull-secrets-store-csi-driver-image-scan failure. Opened #900 to fix new CVEs in base image.

[aramase]

/retitle fix: validate additionalProviderPaths does not contain providers dir