-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apparmor: Add AppArmor info at start time #1079
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
- Coverage 50.43% 50.13% -0.30%
==========================================
Files 42 42
Lines 4761 4789 +28
==========================================
Hits 2401 2401
- Misses 2281 2309 +28
Partials 79 79 |
Noticed that some dependencies were being downgraded as part of the change - reverted such changes. |
This linter warning is confusing:
but it pretty much means that the imports must be sorted alphabetically. I think the linter has a |
the code looks OK to me btw |
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
e197bc4
to
7d207e2
Compare
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
@jhrozek thank you for the review and pointing out the linter issue. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, pjbgf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Provides additional information for users using AppArmor to debug potential setup issues.
An example of what the SPO will write onto logs at the start:
Which issue(s) this PR fixes:
None
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?