-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out host processes by host mntns to prevent ebpf map from filling up during recording #1166
Conversation
|
Welcome @neblen! |
Hi @neblen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you for the PR @neblen, we really appreciate that! May I ask you to sign your commits by signing the EasyCLA? |
ee75717
to
b38063e
Compare
/ok-to-test |
b38063e
to
1b81911
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets run make update-mocks
to re-generate the code.
6f9d5d2
to
ed7aea1
Compare
The CI does not seem to be happy about the changes :) |
It seems that some test cases have not been run, I will check first |
ed7aea1
to
8bc3258
Compare
/retest |
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
- Coverage 48.65% 48.58% -0.07%
==========================================
Files 43 43
Lines 4779 4794 +15
==========================================
+ Hits 2325 2329 +4
- Misses 2358 2367 +9
- Partials 96 98 +2 |
@saschagrunert Hi~ There are still some use cases that fail. I don't know why it didn't pass, would you help me watch it? I'm not particularly familiar with spo's test case flow |
@neblen please rebase, this should fix the CI now. :) |
8bc3258
to
905a7a4
Compare
|
@saschagrunert Hi~ The pull-security-profiles-operator-verify pipeline didn't pass.But I can't see what is directly causing the failure. |
238d39b
to
ac11d7a
Compare
@neblen the linter times-out:
I assume thats because the diff of |
…ing up during recording
ac11d7a
to
8ee4226
Compare
/lgtm Thank you again for you contribution, we really appreciate you time and effort on this topic! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neblen, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Filter out host processes by host mntns to prevent ebpf map from filling up during recording
What type of PR is this?
/kind bug
What this PR does / why we need it:
The current ebpf code saves a lot of host process information, but none of this information is needed. This will cause the ebpf map to fill up during recording. I use the host mntns to filter out the host process so that the data in the ebpf map is only the pid we need to record
Which issue(s) this PR fixes:
Fixes #1165
#1165
Does this PR have test?
N
Special notes for your reviewer:
Does this PR introduce a user-facing change?
N