Use security context to set up the default seccomp profile for spod pod and security-profiles-operator container

[ccojocar]

What type of PR is this?

/kind clean-up

What this PR does / why we need it:

Use security context to set up the default seccomp profile for spod pod and security-profiles-operator container.

Which issue(s) this PR fixes:

security context is a more up to date way to setup the seccomp profile instead of the anotations.

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Use security context to set up the default seccomp profile for spod pod and security-profiles-operator container.

[k8s-ci-robot]

Hi @ccojocar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ccojocar]

/test all

[k8s-ci-robot]

@ccojocar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[saschagrunert]

/ok-to-test

[ccojocar]

This seems like a flaky unit test:

--- FAIL: TestGetOperatorNamespace (0.00s)
    --- PASS: TestGetOperatorNamespace/invalid_one (0.00s)
    --- FAIL: TestGetOperatorNamespace/Valid_one (0.00s)

[k8s-ci-robot]

@ccojocar: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-security-profiles-operator-build
• /test pull-security-profiles-operator-build-image
• /test pull-security-profiles-operator-test-e2e
• /test pull-security-profiles-operator-test-unit
• /test pull-security-profiles-operator-verify

Use /test all to run all jobs.

In response to this:

/test al

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ccojocar]

/test all

[saschagrunert]

Yes I can re-kick the tests once the others finished. Do you need this change as part of v0.5.0, @ccojocar ?

[ccojocar]

It would be great to have it as part of v0.5.0 since we have some issues on cri-o runtime with the current way of setting the seccomp profile.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ccojocar]

I think the issue is that cri-o runtime requires the profile path to be prefix with localhost while other runtime such as docker doesn't: https://github.com/cri-o/cri-o/blob/main/internal/config/seccomp/seccomp.go#L240

I am not sure what's the best way to go about this. How can we detect the runtime and configure the path accordingly?

[saschagrunert]

/lgtm