Add command argument to the daemon which allows to disable profile recorder controller

[ccojocar]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds an command argument to the daemon which allows to disable the profile recorder controller when neither bpf-recorder or log-enricher are enabled.

Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add a command argument to the daemon which allows to disable the profile recorder controller.

[ccojocar]

/assign @saschagrunert

[jhrozek]

Would you also agree with enabling or disabling the controller with an environment variable? I'm thinking this way because of OLM installs where it's very easy to pass an environment variable to the operator through a Subscription object.

[jhrozek]

Also two nits - I think this should be a /kind feature and the switch (and the reason for introducing it) should be mentioned in installation-usage.md. Maybe if you think that the other switches should be mentioned as well, we could have a cleanup ticked that would document them all in one go, but currently our docs are not bad and I'd like to keep everything documented nicely.

[ccojocar]

Would you also agree with enabling or disabling the controller with an environment variable? I'm thinking this way because of OLM installs where it's very easy to pass an environment variable to the operator through a Subscription object.

I'll add an environment variable in addition. What do you think?

[ccojocar]

Also two nits - I think this should be a /kind feature and the switch (and the reason for introducing it) should be mentioned in installation-usage.md. Maybe if you think that the other switches should be mentioned as well, we could have a cleanup ticked that would document them all in one go, but currently our docs are not bad and I'd like to keep everything documented nicely.

I'll do this and also try to add a test.

[codecov-commenter]

Codecov Report

Merging #1290 (cfd7b51) into main (0c22b6f) will increase coverage by 0.06%.
The diff coverage is 45.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1290      +/-   ##
==========================================
+ Coverage   43.92%   43.99%   +0.06%     
==========================================
  Files          49       49              
  Lines        5514     5576      +62     
==========================================
+ Hits         2422     2453      +31     
- Misses       2972     3004      +32     
+ Partials      120      119       -1     

[pjbgf]

Tiny nits, apart from that it is a lgtm from me. Thanks for working on this @ccojocar 🙇.

[ccojocar]

/test all

[ccojocar]

/retest

[ccojocar]

/retest

[ccojocar]

@jhrozek @pjbgf @saschagrunert all checks passed now, please could you have a look at this pull request? Thanks

[saschagrunert]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment