Remove nginx default profile #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
saschagrunert
force-pushed
the
nginx-profile
branch
3 times, most recently
from
6e70846
to
b663e40
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
=======================================
Coverage 44.19% 44.19%
=======================================
Files 50 50
Lines 5636 5636
=======================================
Hits 2491 2491
Misses 3025 3025
Partials 120 120 |
jhrozek
reviewed
Dec 9, 2022
saschagrunert
force-pushed
the
nginx-profile
branch
3 times, most recently
from
081017a
to
c349b2c
Compare
ccojocar
approved these changes
Dec 19, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
saschagrunert
force-pushed
the
nginx-profile
branch
from
c349b2c
to
bf30490
Compare
k8s-ci-robot
removed
lgtm
|
@saschagrunert is there any chance to get this merged soon? The default nginx profile is causing some issues on our side. I cannot manually remove it because the operator keeps install it back. Thanks |
The profile is outdated and we have no automation in place to update it. Means we remove it for now per: kubernetes-sigs#1359 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
nginx-profile
branch
from
bf30490
to
6d67c58
Compare
|
Rebased on top of the latest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
The profile is outdated and we have no automation in place to update it. Means we remove it for now per:
#1359
Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?