-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nginx default profile #1361
Remove nginx default profile #1361
Conversation
6e70846
to
b663e40
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
=======================================
Coverage 44.19% 44.19%
=======================================
Files 50 50
Lines 5636 5636
=======================================
Hits 2491 2491
Misses 3025 3025
Partials 120 120 |
081017a
to
c349b2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am looking forward to see this merged. Thanks for removing it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c349b2c
to
bf30490
Compare
@saschagrunert is there any chance to get this merged soon? The default nginx profile is causing some issues on our side. I cannot manually remove it because the operator keeps install it back. Thanks |
The profile is outdated and we have no automation in place to update it. Means we remove it for now per: kubernetes-sigs#1359 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
bf30490
to
6d67c58
Compare
Rebased on top of the latest |
/lgtm |
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
The profile is outdated and we have no automation in place to update it. Means we remove it for now per:
#1359
Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?