Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint version to v1.51.0 #1453

Merged
merged 6 commits into from
Feb 3, 2023
Merged

Update golangci-lint version to v1.51.0 #1453

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0fd0cb
Update golangci-lint version to v1.51.0
ccojocar Feb 3, 2023
ecabaec
Fix lint warning by avoid using deprecated rand.Seed function
ccojocar Feb 3, 2023
2beb309
Fix lint by removing shadow variable
ccojocar Feb 3, 2023
caedcbb
Ignore lint warning for math/rand which is fine in tests
ccojocar Feb 3, 2023
80543f3
Update golangci-lint version in dependencies
ccojocar Feb 3, 2023
8ed1233
Trigger build
ccojocar Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

GO ?= go

GOLANGCI_LINT_VERSION = v1.50.1
GOLANGCI_LINT_VERSION = v1.51.0
REPO_INFRA_VERSION = v0.2.5
KUSTOMIZE_VERSION = 4.5.7
OPERATOR_SDK_VERSION ?= v1.25.0
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies:
match: CI_IMAGE

- name: golangci-lint
version: 1.50.1
version: 1.51.0
refPaths:
- path: Makefile
match: GOLANGCI_LINT_VERSION
Expand Down
4 changes: 2 additions & 2 deletions test/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,11 +611,11 @@ const (
)

func (e *e2e) getSpodMetrics() string {
rand.Seed(time.Now().UnixNano())
r := rand.New(rand.NewSource(time.Now().UnixNano())) // #nosec
letters := []rune("abcdefghijklmnopqrstuvwxyz")
b := make([]rune, 10)
for i := range b {
b[i] = letters[rand.Intn(len(letters))] //nolint:gosec // fine in tests
b[i] = letters[r.Intn(len(letters))]
}
// Sometimes the metrics command does not output anything in CI. We fix
// that by retrying the metrics retrieval several times.
Expand Down