selinux: Allow using other container-selinux policy templates than container #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
saschagrunert
approved these changes
Feb 22, 2023
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
==========================================
+ Coverage 43.98% 44.06% +0.07%
==========================================
Files 50 50
Lines 5716 5724 +8
==========================================
+ Hits 2514 2522 +8
Misses 3081 3081
Partials 121 121 |
…ntainer The container-selinux package (at least on RHEL/Fedora) ships a number of policy templates. One of them is called simply `container` is special in the sense that using it also creates a `type process`, the others do not. The effect is that if the other templates such as `net_container` should be used, the CIL policy must also include the raw container type. This patch amends the generation of the CIL policy from the SPO-specific format so that the `container` type is always used.
jhrozek
force-pushed
the
udica_templates
branch
from
8f0c951 to
25c2af9
Compare
k8s-ci-robot
removed
the
lgtm
|
New patch version attempts to resolve the verify failure |
JAORMX
approved these changes
Feb 22, 2023
k8s-ci-robot
added
the
lgtm
|
Looks like we're hitting the rate limiter more often: |
saschagrunert
approved these changes
Feb 23, 2023
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, jhrozek, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The container-selinux package (at least on RHEL/Fedora) ships a number
of policy templates. One of them is called simply
containeris specialin the sense that using it also creates a
type process, theothers do not.
The effect is that if the other templates such as
net_containershouldbe used, the CIL policy must also include the raw container type.
This patch amends the generation of the CIL policy from the SPO-specific
format so that the
containertype is always used.Which issue(s) this PR fixes:
None
Does this PR have test?
Yes
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?