Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI artifact platform support #1658

Merged
merged 1 commit into from
May 4, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows pushing and pulling multiple platforms as OCI artifacts.

Which issue(s) this PR fixes:

Refers to #1482

Does this PR have test?

Yes

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added support for platforms (`os[/arch][/variant][:os_version]`) when using seccomp OCI artifact profiles.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 28, 2023
@saschagrunert saschagrunert force-pushed the platform branch 2 times, most recently from d206583 to eb99a6f Compare April 28, 2023 09:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #1658 (e970ad5) into main (ec2eef0) will increase coverage by 0.75%.
The diff coverage is 94.59%.

❗ Current head e970ad5 differs from pull request most recent head 24b66a4. Consider uploading reports for the commit 24b66a4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   48.58%   49.34%   +0.75%     
==========================================
  Files          69       71       +2     
  Lines        6788     6929     +141     
==========================================
+ Hits         3298     3419     +121     
- Misses       3358     3380      +22     
+ Partials      132      130       -2     

@saschagrunert
Copy link
Member Author

@kubernetes-sigs/security-profiles-operator-maintainers PTAL

Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise lgtm.

installation-usage.md Outdated Show resolved Hide resolved
installation-usage.md Outdated Show resolved Hide resolved
installation-usage.md Outdated Show resolved Hide resolved
internal/pkg/artifact/artifact.go Outdated Show resolved Hide resolved
internal/pkg/cli/pusher/options.go Outdated Show resolved Hide resolved
This allows pushing and pulling multiple platforms as OCI artifacts.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Thank you @pjbgf, I addressed all the comments.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ccojocar,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d9e2690 into kubernetes-sigs:main May 4, 2023
@saschagrunert saschagrunert deleted the platform branch May 5, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants