-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update seccompprofile_types.go to change errnoRet to be of type uint #1770
Conversation
Welcome @CoreyCook8! |
Hi @CoreyCook8. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you for this PR @CoreyCook8 🙏 May I ask you to CLA sign-off your commit? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1770 +/- ##
=======================================
Coverage 49.12% 49.12%
=======================================
Files 71 71
Lines 6982 6982
=======================================
Hits 3430 3430
Misses 3418 3418
Partials 134 134 |
Yes, I am just trying to work out some EasyCLA issues 😅. Our CLA Manager is no longer with the team so we are working on fixing that! |
Could I get some 👀 on this when someone has a moment? I would love to fix why these tests are failing but I can't really understand why they're failing from the messages 😬 |
/retest |
@CoreyCook8: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-security-profiles-operator-test-e2e |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CoreyCook8, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR changes the errnoRet to uint as defined here https://github.com/opencontainers/runtime-spec/blob/main/specs-go/config.go#L788C5-L788C5
Which issue(s) this PR fixes:
Fixes #1769
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
yes