Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seccompprofile_types.go to change errnoRet to be of type uint #1770

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

CoreyCook8
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR changes the errnoRet to uint as defined here https://github.com/opencontainers/runtime-spec/blob/main/specs-go/config.go#L788C5-L788C5

Which issue(s) this PR fixes:

Fixes #1769

Does this PR have test?

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes

Changed errnoRet value in the seccomp types definition to be the right type of uint.
Fixed https://github.com/kubernetes-sigs/security-profiles-operator/issues/1769

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 27, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 27, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 27, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @CoreyCook8!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @CoreyCook8. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2023
@saschagrunert
Copy link
Member

Thank you for this PR @CoreyCook8 🙏 May I ask you to CLA sign-off your commit?

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #1770 (f9e441d) into main (06b052d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1770   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files          71       71           
  Lines        6982     6982           
=======================================
  Hits         3430     3430           
  Misses       3418     3418           
  Partials      134      134           

@CoreyCook8
Copy link
Contributor Author

Thank you for this PR @CoreyCook8 🙏 May I ask you to CLA sign-off your commit?

Yes, I am just trying to work out some EasyCLA issues 😅. Our CLA Manager is no longer with the team so we are working on fixing that!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 27, 2023
@CoreyCook8
Copy link
Contributor Author

Could I get some 👀 on this when someone has a moment? I would love to fix why these tests are failing but I can't really understand why they're failing from the messages 😬

@CoreyCook8
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@CoreyCook8: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2023
@saschagrunert saschagrunert reopened this Aug 24, 2023
@saschagrunert
Copy link
Member

/test pull-security-profiles-operator-test-e2e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoreyCook8, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 62fd3dd into kubernetes-sigs:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SeccompProfile errnoRet field is a string but should be a uint
4 participants