Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17164: Fix SelinuxProfile inherit issue #1904

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Oct 4, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

This pr fixes SelinuxProfile inherits another SelinuxProfile. The issue is caused by wrong Inherit type name being used.

Which issue(s) this PR fixes:

Fixes OCPBUGS-17164

Does this PR have test?

Yes

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Fixes a issue when we create a raw SELinux profile that inherit another SELinux profile.

This pr fixes SelinuxProfile inherits another SelinuxProfile. The issue is caused by wrong Inherit type name being used.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2023
@Vincent056 Vincent056 changed the title OCPBUGS-17164: Fix SelinuxProfile inherit issue WIP OCPBUGS-17164: Fix SelinuxProfile inherit issue Oct 5, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2023
@saschagrunert
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 5, 2023
@Vincent056 Vincent056 changed the title WIP OCPBUGS-17164: Fix SelinuxProfile inherit issue OCPBUGS-17164: Fix SelinuxProfile inherit issue Oct 6, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@JAORMX
Copy link
Contributor

JAORMX commented Oct 6, 2023

/retest

@codecov-commenter
Copy link

Codecov Report

Merging #1904 (79f0016) into main (f8fab34) will decrease coverage by 0.01%.
Report is 68 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
- Coverage   49.23%   49.22%   -0.01%     
==========================================
  Files          71       72       +1     
  Lines        7024     7033       +9     
==========================================
+ Hits         3458     3462       +4     
- Misses       3432     3437       +5     
  Partials      134      134              

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 788ee6c into kubernetes-sigs:main Oct 9, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants