Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17164: Fix SELinuxprofile inherit issue #1919

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Oct 13, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

In conjunction to PR#1904, this pr is also needed in order to fix the selinux profile inherit issue, do not inherit system container on all selinuxprofile. In additional, the .process suffix is breaking the profile install as well, so it is now removed.

Which issue(s) this PR fixes:

Fixes # OCPBUGS-17164

Does this PR have test?

Yes

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

In conjunction to PR#1904, this pr is also needed in order to fix the selinux profile inherit issue for [OCPBUGS-17164](https://issues.redhat.com/browse/OCPBUGS-17164), do not add inherit system container line when we have selinuxprofile inherit.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #1919 (8cc8215) into main (db43880) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
+ Coverage   49.22%   49.25%   +0.02%     
==========================================
  Files          72       72              
  Lines        7033     7037       +4     
==========================================
+ Hits         3462     3466       +4     
  Misses       3437     3437              
  Partials      134      134              

In conjunction to PR#1904, this pr is also needed in order to fix the selinux profile inherit issue, do not inherit system container on all selinuxprofile
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit c7d0659 into kubernetes-sigs:main Oct 13, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants