-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spoc convert
Command
#2201
Add spoc convert
Command
#2201
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This command allows users to transform security profiles from a custom resource definition YAML to the raw profile as consumed by the respective security module.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2201 +/- ##
==========================================
- Coverage 45.50% 41.14% -4.37%
==========================================
Files 79 107 +28
Lines 7782 15529 +7747
==========================================
+ Hits 3541 6389 +2848
- Misses 4099 8670 +4571
- Partials 142 470 +328 |
/ok-to-test Thank you @mhils 🙏 ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhils, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
This command allows users to transform security profiles from a custom resource definition YAML to the raw profile as consumed by the respective security module. My primary use case here is testing AppArmor rules without dealing with Kubernetes, but it works for seccomp just as well.
Which issue(s) this PR fixes:
None
Does this PR have test?
Yes.
Special notes for your reviewer:
This PR first consolidates the code paths in
artifact
andmerger
to read YAML files (fixing ab bug in the artifact impl, see #2136 (comment)), and then reuses that for the convert functionality. It's probably easiest to review commits individually.Happy to bikeshed on the name of the command if you feel
convert
is too generic. I hold no strong opinions. :)Does this PR introduce a user-facing change?