-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppArmor: Add read permission for executables #2554
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
==========================================
- Coverage 45.50% 41.29% -4.22%
==========================================
Files 79 109 +30
Lines 7782 18234 +10452
==========================================
+ Hits 3541 7529 +3988
- Misses 4099 10208 +6109
- Partials 142 497 +355 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, mhils The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mhils Is this based on latest main, it seems that the base image used by the ubi-image still has a high vulnerability https://github.com/kubernetes-sigs/security-profiles-operator/actions/runs/11817934755/job/32929688477?pr=2554, but I saw that @saschagrunert bumped its version. |
/test pull-security-profiles-operator-test-e2e |
7b552de
to
2646cac
Compare
/ok-to-test |
@mhils If this doesn't pass could you please rebase it on main branch, we removed the image scanner for now because it seems that trivy rate limited their database image and is now causing a lot of timeout errors. |
Please rebase to fix the CI. |
fb3bdb6
to
1d23276
Compare
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Depending on how processes are spawned,
ix
is not enough and we also need to explicitly permit reading the executable.Which issue(s) this PR fixes:
None
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?