selinux: Print diagnostic message from selinuxd in event on failure #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selinuxd does include a diagnostic message for some time and we even parse it, it was just unused. Instead of changing the CRD just to include an error message, we might as well just dump the message in an event.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 43.73% 44.02% +0.28%
==========================================
Files 26 26
Lines 1324 1338 +14
==========================================
+ Hits 579 589 +10
- Misses 705 709 +4
Partials 40 40 |
saschagrunert
approved these changes
Jul 28, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
selinuxd does include a diagnostic message for some time and we even
parse it, it was just unused. Instead of changing the CRD just to
include an error message, we might as well just dump the message in an
event.
Which issue(s) this PR fixes:
Fixes #223 (sort of? The issue talked about enhancing the CRD which I
don't think is needed honestly..)
Does this PR have test?
N/A
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?