Make webhooks' failurePolicy and namespaceSelector configurable #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
removed
the
needs-rebase
jhrozek
force-pushed
the
webhook-ns
branch
2 times, most recently
from
bb5aae4
to
d6b6d11
Compare
|
/test pull-security-profiles-operator-test-e2e |
k8s-ci-robot
added
the
lgtm
|
/test pull-security-profiles-operator-test-e2e |
|
hmm, changing the verbosity seems to be flaky lately..not sure if it's related to this PR though... |
|
/test pull-security-profiles-operator-test-e2e |
|
oops, I can reproduce the issue locally. Stupid tests, finding issues in my code.. |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
By default, our webhooks target all namespaces. While from a security standpointm this is OK, because the webhooks react to our CRs and therefore an explicit RBAC rule must be added to manage them, there is still a risk that if there is a bug in the webhooks, the function of critical namespaces might be affected. This patch exposes the failureMode and the namespaceSelector as configurable through a newly added webhookOptions object in the spod CR to enable admins to select which namespaces should be watched by the webhook and what should happen on failure. In addition, namespace runlevels 0 and 1 are ignored by defualt on OCP. Signed-off-by: Jakub Hrozek <jhrozek@redhat.com>
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
saschagrunert
approved these changes
Apr 6, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
By default, our webhooks target all namespaces. While from a security
standpointm this is OK, because the webhooks react to our CRs and
therefore an explicit RBAC rule must be added to manage them, there is
still a risk that if there is a bug in the webhooks, the function of
critical namespaces might be affected.
This patch exposes the failureMode and the namespaceSelector as
configurable through a newly added webhookOptions object in the spod CR
to enable admins to select which namespaces should be watched by the
webhook and what should happen on failure.
In addition, namespace runlevels 0 and 1 are ignored by defualt on OCP.
Which issue(s) this PR fixes:
Fixes #672
Does this PR have test?
Yes, an e2e test was added.
Special notes for your reviewer:
I'll point a question inline.
Does this PR introduce a user-facing change?