Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RateLimiter arg so that callers can pass their own workqueue.RateLimiter #12

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jan 16, 2019

/cc @jsafrane

@k8s-ci-robot k8s-ci-robot requested a review from jsafrane January 16, 2019 19:28
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2019
@jsafrane
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1a00ed7 into kubernetes-sigs:master Jan 17, 2019
k8s-ci-robot added a commit that referenced this pull request Jan 18, 2019
humblec pushed a commit to humblec/sig-storage-lib-external-provisioner that referenced this pull request Jun 18, 2020
build.make: avoid unit-testing E2E test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants