Fixed logging of unrelated PVCs #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every PVC in the cluster all provisioners in the cluster logged: I0806 11:06:12.926999 1 controller.go:979] Final error received, removing PVC 33dc3c59-b83a-11e9-ab9f-0269002b1a92 from claims in progress I0806 11:06:12.927129 1 controller.go:902] Provisioning succeeded, removing PVC 33dc3c59-b83a-11e9-ab9f-0269002b1a92 from claims in progress This is confusing, as it was logged also for PVCs that were not provisioned by the provisioner. This patch reorders the handling, so claims in progress are used only for PVCs that "should" be processed (i.e. have the right provisioning annotation).
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
jsafrane
force-pushed
the
fix-unrelated-pvc-logging
branch
from
1b85d91 to
aef7290
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
humblec
pushed a commit
to humblec/sig-storage-lib-external-provisioner
that referenced
this pull request
Jun 18, 2020
fix syntax for ppc64le build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder the handling, so claims in progress are used only for PVCs that "should" be processed (i.e. have the right provisioning annotation).
I moved most of the handling into
syncClaim, leaving one silentclaimsInProgress.DeleteinprocessNextClaimWorkItemwhenerris nil to catch all theelsebranches where the PVC is ignored by the controller insyncClaimHandler/syncClaim.Fixes #53