Helm chart rework v2

[HaveFun83]

Did some refactoring on the helm chart to match the helm best practices

• split deployment files into "single objects"
• join values from rbac and serviceAccount
• removed namespace creation. As helm v2 will create one during install and on helm v3 the namespace must already created before install.
• removed common.configMapName . This will be generated from the release-name
• removed daemonset.name. This will be generated from the helm release-name
• removed daemonset.serviceAccount This will be generated from the helm release-name
• changed metadata.labels
• rework the Prometheus servicemonitor creation
• added generation / verify for helm v2 and helm v3

Please have a look. Feedback is welcome
Thanks

@cofyc sorry i opened a new pr as i messed up the old one

[k8s-ci-robot]

Hi @HaveFun83. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[HaveFun83]

/assign @cofyc

[HaveFun83]

@cofyc any news here?

[cofyc]

why this is removed?

[HaveFun83]

because:

removed namespace creation. As helm v2 will create one during install and on helm v3 the namespace must already created before install.

[cofyc]

got it

[cofyc]

the format of the new values LGTM, but we should make the new chart backward compatible with old values yaml as possible as we can, e.g.

• daemonset.name override the name of DaemonSet if present
• common.configMapName overrides the name of ConfigMap if present
• common. podSecurityPolicy overrides the rbac.pspEnabled if present
• etc.

then, people can use the old values file with the new chart and don't worry about any problems during upgrading.

[HaveFun83]

I can do this but it means duplication in the value / chart template files which is not a good approach in my eyes.
Please have look in the helm/Readme.md i added a section about upgrading.
During tests within vagrant i saw no issues during upgrading from old to new chart version.

[cofyc]

ok

[cofyc]

/ok-to-test

[cofyc]

/lgtm
/approve

Great work!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, HaveFun83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cofyc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[HaveFun83]

@cofyc big thanks for your support and review.