Add gcloud build configuration #206
Conversation
|
@cofyc: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/M
cofyc
force-pushed
the
fix153
branch
2 times, most recently
from
35282cd to
927e767
Compare
|
/assign @msau42 |
| DOCKER_CONFIG optional docker config location | ||
| CONFIRM set this to skip confirmation | ||
| ALLOW_UNSTABLE by default, only master branch and tags that matches v<major>.<minor>.<patch> format are allowed, set this to skip this check (debug only) | ||
| ALLOW_DIRTY by default, git repo must be clean, set this to skip this check (debug only) | ||
| ALLOW_OVERRIDE by default, stable image is not allowed to override, set this to skip (debug only) | ||
| SKIP_BUILD set this to skip build phase (debug only) | ||
| SKIP_PUSH_LATEST set this to skip pushing the latest stable image as the latest image |
There was a problem hiding this comment.
current prow job does not include .git directory, I add this to skip checking if the tag is the latest.
the latest tag is not recommended in production, I think it's fine not pushing it.
cofyc
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
cofyc
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| - ALLOW_DIRTY=yes | ||
| - ALLOW_UNSTABLE=yes | ||
| - CONFIRM=yes | ||
| - SKIP_PUSH_LATEST=yes |
There was a problem hiding this comment.
How will we support the canary job? https://k8s-testgrid.appspot.com/sig-storage-local-static-provisioner#master-gce-lastest
There was a problem hiding this comment.
Oh I see canary is different from latest
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cofyc, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add gcloud build configuration
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: