Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volunteer reviewers #266

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add volunteer reviewers #266

merged 1 commit into from
Oct 31, 2024

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Oct 31, 2024

A few seasoned API Machinery contributors have graciously volunteered to help fill the reviewer ranks here.

Thanks @Jefftree @yliaog @cici37

/sig api-machinery

/assign @apelisse

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from apelisse October 31, 2024 20:01
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 31, 2024

cc @deads2k

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 31, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Oct 31, 2024
@deads2k
Copy link

deads2k commented Oct 31, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@jpbetz jpbetz merged commit b499124 into kubernetes-sigs:master Oct 31, 2024
4 of 5 checks passed
@apelisse
Copy link
Contributor

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants