-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'multi-arch' windows-gmsa-webhook container image to support arm64. #107
Comments
This might just work if we update the GOARCH variable to be configurable in the dockerfile, pass that through the makefile, and create a manfest in the makefile when pushing.
windows-gmsa/admission-webhook/make/image.mk Lines 10 to 17 in fa115c8
We might want a CI job eventually, but I don't think github actions supports ARM64 right now. |
azure-cni seems to use github action to build, they started to build 'multi-arch' container images 20 months ago since this PR |
I tested this by setting I can work on building / publishing a multi-arch image with linux/amd64 and linux/arm64 arches but I probably won't be able to do it until next week (week of May 15) |
building on github actions should work, but we won't be able to run CI tests against it. |
@marosset any update on 'multi-arch' windows-gmsa-webhook' container image? |
Working on it now :) |
Currently windows-gmsa-webhook container image in upstream only supports amd64. AKS supports ARM64 Ubuntu/Mariner nodes. So when customer creates an AKS cluster with windows-gmsa enabled (e.g. az aks create --enable-windows-gmsa --node-vm-size <arm64_SKU>...), the windows-gmsa-webhook pod cannot start on arm64 Linux nodes. We need 'multi-arch' windows-gmsa-webhook container image so that windows-gmsa feature can work properly on AKS arm64 cluster, just like any other addon container images used on AKS linux nodes.
Use coredns 'multi-arch' container images as an example blow.
The text was updated successfully, but these errors were encountered: