Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 docker #1030

Merged
merged 5 commits into from
Sep 28, 2021
Merged

Arm64 docker #1030

merged 5 commits into from
Sep 28, 2021

Conversation

pjohnst5
Copy link
Contributor

Reason for Change:
This adds arm64 docker images for Azure CNS and Azure NPM.
Uses docker buildx to do this, which makes it possible for the clients to pull which arch image they need at runtime dynically, and keep the same tag for both amd64 and arm64. Read more about it here

https://wiki.onap.org/display/DW/Building+a+Platform-Agnostic+Container+Image
https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/

@pjohnst5 pjohnst5 force-pushed the arm64-docker branch 4 times, most recently from 37fc00f to e767aa0 Compare September 24, 2021 17:27
@pjohnst5 pjohnst5 marked this pull request as ready for review September 24, 2021 19:01
Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some immediate comments

Makefile Outdated Show resolved Hide resolved
npm/Dockerfile Outdated Show resolved Hide resolved
npm/Dockerfile Show resolved Hide resolved
.pipelines/npm/npm-conformance-tests.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants