Update helm chart crds folder location

[Fareroo7]

No description provided.

[jsturtevant]

@Fareroo7 could you give some context on this change? we shouldn't be modifying the 0.4 package for the chart. If any updates are needed it should be a new version

[Fareroo7]

@jsturtevant when I tried to install this chart, I got an error that the crds were missing.
I'm using helm v3 and it couldn't install the crds because of the wrong location of the crds dir.

[jsturtevant]

@phillipsj could you take a look? I though our chart-integration test would cover this scenario but it looks like it isn't using the correct flow and instead using the deploy script:

KUBECONFIG=/home/runner/work/windows-gmsa/windows-gmsa/admission-webhook/dev/kubeconfig-windows-gmsa-chart-integration KUBECTL=/usr/local/bin/kubectl ./deploy/deploy-gmsa-webhook.sh --file "/home/runner/work/windows-gmsa/windows-gmsa/admission-webhook/dev/gmsa-webhook.yml" --name "windows-gmsa-dev" --namespace "windows-gmsa-dev" --image "sigwindowstools/k8s-gmsa-webhook" --certs-dir "/home/runner/work/windows-gmsa/windows-gmsa/admission-webhook/dev/certs_dir" 
Generating RSA private key, 2048 bit long modulus (2 primes)
..........................................................+++++

[phillipsj]

Will do

[phillipsj]

PR up to fix the integration tests. We should rebase once that is merged. #75

[jsturtevant]

@Fareroo7 could you take a look if the changes in #75 help? If moving the CRD's still makes sense could you rebase it? Thanks!

[Fareroo7]

@phillipsj thanks that changes are looking good but I still moved the crds folder one directory up, otherwise the crds won't be installed by helm

@jsturtevant I did a rebase and now the chart works like a charm

[jsturtevant]

good to hear!

I don't think we should be regenerating the helm packages for 0.4.0 and 0.4.1. We could generate a 0.4.2 with your patch

[marosset]

good to hear!

I don't think we should be regenerating the helm packages for 0.4.0 and 0.4.1. We could generate a 0.4.2 with your patch

+1 for 0.4.2

[Fareroo7]

of course, silly me...

[jsturtevant]

@Fareroo7 could you squash the commits?

/lgtm
/assign @marosset @phillipsj

[marosset]

LGTM
We can merge after commits get squashed
Thanks!

[jsturtevant]

@Fareroo7 the chart tests is failing now which might be caused by the main branch being merged into this PR. Could you include just your change commit?

[Fareroo7]

my bad ...
first time squashing commits 👶🏻😄

[jsturtevant]

no worries! Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fareroo7, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsturtevant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment