Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update pause-win image to the new one k8s.gcr.io/pause:3.4.1 #246

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 11, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As part of the efforts described in this Issue: kubernetes/k8s.io#1525 we are trying to move away from gcp project gke-release

Also the pause image was release with windows support as we can see in the merged or in k/k kubernetes/kubernetes#98205

/assign @spiffxp @jayunit100

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 11, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2021
@pjh
Copy link
Contributor

pjh commented Feb 11, 2021

Thanks Carlos. We'll also need to update the corresponding load test config.

Do you want to do that, or should our team prepare a PR for that?

@cpanato
Copy link
Member Author

cpanato commented Feb 11, 2021

@pjh there is a PR up for that kubernetes/perf-tests#1730 🙃

@jeremyje
Copy link
Contributor

jeremyje commented Feb 11, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2021
@pjh
Copy link
Contributor

pjh commented Feb 11, 2021

/lgtm

Thanks!

@jeremyje
Copy link
Contributor

/approval

@cpanato
Copy link
Member Author

cpanato commented Feb 12, 2021

@jeremyje can you issue the /approve instead of approval 😄

thanks

@claudiubelu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, cpanato, jeremyje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5e711d1 into kubernetes-sigs:master Feb 12, 2021
@cpanato cpanato deleted the K8sio-GH-1525 branch February 12, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants