Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hack/update-codegen.sh failed to generates the code in right place #31

Merged

Conversation

RainbowMango
Copy link
Member

When I try to fix issue #30, I found the hack/update-codegen.sh actually not working.

It will generates the files at repo/sigs.k8s.io/... instead of repo/pkg/....

-bash-5.0# hack/update-codegen.sh 
Generating deepcopy funcs
Generating clientset at sigs.k8s.io/work-api/pkg/client/clientset
Generating listers at sigs.k8s.io/work-api/pkg/client/listers
Generating informers at sigs.k8s.io/work-api/pkg/client/informers
Generating register at sigs.k8s.io/work-api/pkg/apis/v1alpha1
-bash-5.0# git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	sigs.k8s.io/

nothing added to commit but untracked files present (use "git add" to track)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2024
@RainbowMango
Copy link
Member Author

/hold
wait for #32

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango
Copy link
Member Author

/hold cancel
cc @qiujian16 @mikeshng

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@qiujian16
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2c2253a into kubernetes-sigs:master May 21, 2024
6 checks passed
@RainbowMango RainbowMango deleted the pr_fix_update_codegen branch May 21, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants