Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error reporting JSON vs YAML #9

Closed
neolit123 opened this issue Nov 5, 2018 · 6 comments
Closed

improve error reporting JSON vs YAML #9

neolit123 opened this issue Nov 5, 2018 · 6 comments
Labels
kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@neolit123
Copy link
Member

neolit123 commented Nov 5, 2018

the errors of this library need work.
with the strict JSON decoder unknown fields would result in errors such as:

error unmarshaling JSON: .....: json: unknown field "z";

this gives a hint that "z" is unknown.
but the user would first of all be confused why is the error throw to stdout about JSON, while their e.g. manifest is in YAML.

xref: #7

@neolit123
Copy link
Member Author

/kind cleanup
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 10, 2018
@errordeveloper
Copy link

It would be great if we could fix this, the error messages are very very confusing to end-users.

@neolit123
Copy link
Member Author

problem here is that all the backends out there including encoding/json yaml.2/3, json-iter don't have good typed errors. this leaves us in a space where we need to parse strings, modify them and return proper errors.

i'm -1 on that, so it's probably best to wait on the backends to fix them, or attempt to push patches upstream.

/remove-kind cleanup
/kind design
/remove-priority important-longterm
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/design Categorizes issue or PR as related to design. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 26, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2019
@neolit123
Copy link
Member Author

as explained here this is far from ideal:
#9 (comment)

if someone wishes to help please open tickets for yaml v2/v3 and json-iter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants