Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go.mod #25

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Fix go.mod #25

merged 2 commits into from
Jul 4, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jul 4, 2019 •
edited

Fixes #24

github.com/davecgh/go-spew is required by yaml_test.go which was added in #14.

This was not caught in tests because we just run a go test, which updates go.mod but we don't check if there were any new changes. This PR fixes it.

/cc @sttts @neolit123 @dims

@k8s-ci-robot
Copy link

Welcome @nikhita!

It looks like this is your first PR to kubernetes-sigs/yaml 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/yaml has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2019
neolit123
neolit123 reviewed Jul 4, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @nikhita

go.mod
@@ -1,5 +1,8 @@
module github.com/kubernetes-sigs/yaml
module sigs.k8s.io/yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2019
@sttts
Copy link

sttts commented Jul 4, 2019

In the readme it is also called kubernetes-sigs/yaml. How do we use it in kube?

@sttts
Copy link

sttts commented Jul 4, 2019

It's sigs.k8s.io/yaml in kube's imports.

@sttts
Copy link

sttts commented Jul 4, 2019

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4cd0c28 into kubernetes-sigs:master Jul 4, 2019
@nikhita nikhita deleted the gomod branch July 5, 2019 02:40
@thaJeztah thaJeztah mentioned this pull request Nov 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@dims dims Awaiting requested review from dims

@sttts sttts Awaiting requested review from sttts

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go.mod module name is wrong, should be: sigs.k8s.io/yaml
4 participants
@nikhita @k8s-ci-robot @sttts @neolit123