-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix go.mod #25
Fix go.mod #25
Conversation
Welcome @nikhita! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks @nikhita
@@ -1,5 +1,8 @@ | |||
module github.com/kubernetes-sigs/yaml | |||
module sigs.k8s.io/yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In the readme it is also called kubernetes-sigs/yaml. How do we use it in kube? |
It's sigs.k8s.io/yaml in kube's imports. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #24
github.com/davecgh/go-spew
is required byyaml_test.go
which was added in #14.This was not caught in tests because we just run a
go test
, which updatesgo.mod
but we don't check if there were any new changes. This PR fixes it./cc @sttts @neolit123 @dims