Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gopkg.in/laverya/yaml.v3 instead of gopkg.in/yaml.v2 #26

Closed
wants to merge 3 commits into from
Closed

use gopkg.in/laverya/yaml.v3 instead of gopkg.in/yaml.v2 #26

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de1d76d
use gopkg.in/laverya/yaml.v3 instead of gopkg.in/yaml.v2
laverya Jul 10, 2019
fa78b40
go fmt fixes
laverya Jul 10, 2019
45ba999
support duplicate keys with v3.0.0-beta2 of laverya/yaml.v3
laverya Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ go 1.12

require (
github.com/davecgh/go-spew v1.1.1
gopkg.in/laverya/yaml.v3 v3.0.0-beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why include v3 from your fork. what differences it has from upstream?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two major ones - the first is that it has tags
The second is the inclusion of go-yaml/yaml#455 - "Add a function to set the desired line length of an Encoder" which would resolve kubernetes-sigs/kustomize#947

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full diff is here: go-yaml/yaml@v3...laverya:v3.0.0-beta1
7 additional commits

gopkg.in/yaml.v2 v2.2.2
)
3 changes: 3 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/laverya/yaml.v3 v3.0.0-beta1 h1:RdsAorqInkY9GHKpfOE383oGybyNXxnKucVMCrBFmYo=
gopkg.in/laverya/yaml.v3 v3.0.0-beta1/go.mod h1:b5w3YJ/R5MxUkx01JYEDFaW9XiYHxEm6iaCHIN+jaRE=
gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw=
gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
15 changes: 15 additions & 0 deletions vendor/github.com/davecgh/go-spew/LICENSE
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

145 changes: 145 additions & 0 deletions vendor/github.com/davecgh/go-spew/spew/bypass.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 38 additions & 0 deletions vendor/github.com/davecgh/go-spew/spew/bypasssafe.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading