Skip to content

Commit

Permalink
Revert "Field status.hostIPs added for Pod (#101566)"
Browse files Browse the repository at this point in the history
This reverts commit 61b3c028ba618a939559c39befb546ae5e5fd0b9.

Kubernetes-commit: 1108bed7631f545d43530aa697175d243b99610b
  • Loading branch information
Argh4k authored and k8s-publishing-bot committed Mar 30, 2022
1 parent 290a349 commit 1eb735b
Show file tree
Hide file tree
Showing 11 changed files with 1,052 additions and 1,353 deletions.
2,293 changes: 1,036 additions & 1,257 deletions core/v1/generated.pb.go

Large diffs are not rendered by default.

29 changes: 6 additions & 23 deletions core/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 6 additions & 24 deletions core/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -3605,15 +3605,11 @@ type PodDNSConfigOption struct {
Value *string `json:"value,omitempty" protobuf:"bytes,2,opt,name=value"`
}

// PodIP address information for entries in the (plural) PodIPs field.
// IP address information for entries in the (plural) PodIPs field.
// Each entry includes:
// IP: An IP address allocated to the pod. Routable at least within the cluster.
type PodIP struct {
// IP is the IP address assigned to the pod
IP string `json:"ip,omitempty" protobuf:"bytes,1,opt,name=ip"`
}

// HostIP address information for entries in the (plural) HostIPs field.
type HostIP struct {
// IP is the IP address assigned to the host
// ip is an IP address (IPv4 or IPv6) assigned to the pod
IP string `json:"ip,omitempty" protobuf:"bytes,1,opt,name=ip"`
}

Expand Down Expand Up @@ -3834,24 +3830,10 @@ type PodStatus struct {
// +optional
NominatedNodeName string `json:"nominatedNodeName,omitempty" protobuf:"bytes,11,opt,name=nominatedNodeName"`

// hostIP holds the IP address of the host to which the pod is assigned.
// Empty if the pod has not started yet.
// A pod can be assigned to a node that has a problem in kubelet which in turns mean that HostIP will
// not be updated even if there is node is assigned to pod
// IP address of the host to which the pod is assigned. Empty if not yet scheduled.
// +optional
HostIP string `json:"hostIP,omitempty" protobuf:"bytes,5,opt,name=hostIP"`

// hostIPs holds the IP addresses allocated to the host. If this field is specified, the first entry must
// match the hostIP field. This list is empty if the pod has not started yet.
// A pod can be assigned to a node that has a problem in kubelet which in turns means that HostIPs will
// not be updated even if there is a node is assigned to this pod.
// +optional
// +patchStrategy=merge
// +patchMergeKey=ip
// +listType=set
HostIPs []HostIP `json:"hostIPs,omitempty" protobuf:"bytes,14,rep,name=hostIPs" patchStrategy:"merge" patchMergeKey:"ip"`

// podIP address allocated to the pod. Routable at least within the cluster.
// IP address allocated to the pod. Routable at least within the cluster.
// Empty if not yet allocated.
// +optional
PodIP string `json:"podIP,omitempty" protobuf:"bytes,6,opt,name=podIP"`
Expand Down
18 changes: 4 additions & 14 deletions core/v1/types_swagger_doc_generated.go
Original file line number Diff line number Diff line change
Expand Up @@ -825,15 +825,6 @@ func (HostAlias) SwaggerDoc() map[string]string {
return map_HostAlias
}

var map_HostIP = map[string]string{
"": "HostIP address information for entries in the (plural) HostIPs field.",
"ip": "IP is the IP address assigned to the host",
}

func (HostIP) SwaggerDoc() map[string]string {
return map_HostIP
}

var map_HostPathVolumeSource = map[string]string{
"": "Represents a host path mapped into a pod. Host path volumes do not support ownership management or SELinux relabeling.",
"path": "path of the directory on the host. If the path is a symlink, it will follow the link to the real path. More info: https://kubernetes.io/docs/concepts/storage/volumes#hostpath",
Expand Down Expand Up @@ -1543,8 +1534,8 @@ func (PodExecOptions) SwaggerDoc() map[string]string {
}

var map_PodIP = map[string]string{
"": "PodIP address information for entries in the (plural) PodIPs field.",
"ip": "IP is the IP address assigned to the pod",
"": "IP address information for entries in the (plural) PodIPs field. Each entry includes:\n IP: An IP address allocated to the pod. Routable at least within the cluster.",
"ip": "ip is an IP address (IPv4 or IPv6) assigned to the pod",
}

func (PodIP) SwaggerDoc() map[string]string {
Expand Down Expand Up @@ -1692,9 +1683,8 @@ var map_PodStatus = map[string]string{
"message": "A human readable message indicating details about why the pod is in this condition.",
"reason": "A brief CamelCase message indicating details about why the pod is in this state. e.g. 'Evicted'",
"nominatedNodeName": "nominatedNodeName is set only when this pod preempts other pods on the node, but it cannot be scheduled right away as preemption victims receive their graceful termination periods. This field does not guarantee that the pod will be scheduled on this node. Scheduler may decide to place the pod elsewhere if other nodes become available sooner. Scheduler may also decide to give the resources on this node to a higher priority pod that is created after preemption. As a result, this field may be different than PodSpec.nodeName when the pod is scheduled.",
"hostIP": "hostIP holds the IP address of the host to which the pod is assigned. Empty if the pod has not started yet. A pod can be assigned to a node that has a problem in kubelet which in turns mean that HostIP will not be updated even if there is node is assigned to pod",
"hostIPs": "hostIPs holds the IP addresses allocated to the host. If this field is specified, the first entry must match the hostIP field. This list is empty if the pod has not started yet. A pod can be assigned to a node that has a problem in kubelet which in turns means that HostIPs will not be updated even if there is a node is assigned to this pod.",
"podIP": "podIP address allocated to the pod. Routable at least within the cluster. Empty if not yet allocated.",
"hostIP": "IP address of the host to which the pod is assigned. Empty if not yet scheduled.",
"podIP": "IP address allocated to the pod. Routable at least within the cluster. Empty if not yet allocated.",
"podIPs": "podIPs holds the IP addresses allocated to the pod. If this field is specified, the 0th entry must match the podIP field. Pods may be allocated at most 1 value for each of IPv4 and IPv6. This list is empty if no IPs have been allocated yet.",
"startTime": "RFC 3339 date and time at which the object was acknowledged by the Kubelet. This is before the Kubelet pulled the container image(s) for the pod.",
"initContainerStatuses": "The list has one entry per init container in the manifest. The most recent successful init container will have ready = true, the most recently started container will have startTime set. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#pod-and-container-status",
Expand Down
21 changes: 0 additions & 21 deletions core/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions testdata/HEAD/core.v1.Pod.json
Original file line number Diff line number Diff line change
Expand Up @@ -1582,11 +1582,6 @@
"reason": "reasonValue",
"nominatedNodeName": "nominatedNodeNameValue",
"hostIP": "hostIPValue",
"hostIPs": [
{
"ip": "ipValue"
}
],
"podIP": "podIPValue",
"podIPs": [
{
Expand Down
Binary file modified testdata/HEAD/core.v1.Pod.pb
Binary file not shown.
2 changes: 0 additions & 2 deletions testdata/HEAD/core.v1.Pod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1159,8 +1159,6 @@ status:
message: messageValue
reason: reasonValue
hostIP: hostIPValue
hostIPs:
- ip: ipValue
initContainerStatuses:
- containerID: containerIDValue
image: imageValue
Expand Down
5 changes: 0 additions & 5 deletions testdata/HEAD/core.v1.PodStatusResult.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@
"reason": "reasonValue",
"nominatedNodeName": "nominatedNodeNameValue",
"hostIP": "hostIPValue",
"hostIPs": [
{
"ip": "ipValue"
}
],
"podIP": "podIPValue",
"podIPs": [
{
Expand Down
Binary file modified testdata/HEAD/core.v1.PodStatusResult.pb
Binary file not shown.
2 changes: 0 additions & 2 deletions testdata/HEAD/core.v1.PodStatusResult.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ status:
message: messageValue
reason: reasonValue
hostIP: hostIPValue
hostIPs:
- ip: ipValue
initContainerStatuses:
- containerID: containerIDValue
image: imageValue
Expand Down

0 comments on commit 1eb735b

Please sign in to comment.