Merge pull request #116469 from RomanBednar/pv-phase-transition-time

PersistentVolume last phase transition time Kubernetes-commit: f3a070f9c684d9335b6df91ef2f3ce207629882c
kubernetes · Jul 22, 2023 · 2859edb · 2859edb
2 parents 6ff1b21 + 43c3eb6
commit 2859edb
Show file tree

Hide file tree

Showing 8 changed files with 951 additions and 876 deletions.
diff --git a/core/v1/generated.pb.go b/core/v1/generated.pb.go
diff --git a/core/v1/generated.proto b/core/v1/generated.proto
diff --git a/core/v1/types.go b/core/v1/types.go
@@ -411,6 +411,12 @@ type PersistentVolumeStatus struct {
 	// for machine parsing and tidy display in the CLI.
 	// +optional
 	Reason string `json:"reason,omitempty" protobuf:"bytes,3,opt,name=reason"`
+	// lastPhaseTransitionTime is the time the phase transitioned from one to another
+	// and automatically resets to current time everytime a volume phase transitions.
+	// This is an alpha field and requires enabling PersistentVolumeLastPhaseTransitionTime feature.
+	// +featureGate=PersistentVolumeLastPhaseTransitionTime
+	// +optional
+	LastPhaseTransitionTime *metav1.Time `json:"lastPhaseTransitionTime,omitempty" protobuf:"bytes,4,opt,name=lastPhaseTransitionTime"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

diff --git a/core/v1/types_swagger_doc_generated.go b/core/v1/types_swagger_doc_generated.go
@@ -1446,10 +1446,11 @@ func (PersistentVolumeSpec) SwaggerDoc() map[string]string {
 }
 
 var map_PersistentVolumeStatus = map[string]string{
-	"":        "PersistentVolumeStatus is the current status of a persistent volume.",
-	"phase":   "phase indicates if a volume is available, bound to a claim, or released by a claim. More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#phase",
-	"message": "message is a human-readable message indicating details about why the volume is in this state.",
-	"reason":  "reason is a brief CamelCase string that describes any failure and is meant for machine parsing and tidy display in the CLI.",
+	"":                        "PersistentVolumeStatus is the current status of a persistent volume.",
+	"phase":                   "phase indicates if a volume is available, bound to a claim, or released by a claim. More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#phase",
+	"message":                 "message is a human-readable message indicating details about why the volume is in this state.",
+	"reason":                  "reason is a brief CamelCase string that describes any failure and is meant for machine parsing and tidy display in the CLI.",
+	"lastPhaseTransitionTime": "lastPhaseTransitionTime is the time the phase transitioned from one to another and automatically resets to current time everytime a volume phase transitions. This is an alpha field and requires enabling PersistentVolumeLastPhaseTransitionTime feature.",
 }
 
 func (PersistentVolumeStatus) SwaggerDoc() map[string]string {

diff --git a/core/v1/zz_generated.deepcopy.go b/core/v1/zz_generated.deepcopy.go
diff --git a/testdata/HEAD/core.v1.PersistentVolume.json b/testdata/HEAD/core.v1.PersistentVolume.json
@@ -304,6 +304,7 @@
   "status": {
     "phase": "phaseValue",
     "message": "messageValue",
-    "reason": "reasonValue"
+    "reason": "reasonValue",
+    "lastPhaseTransitionTime": "2004-01-01T01:01:01Z"
   }
 }
diff --git a/testdata/HEAD/core.v1.PersistentVolume.pb b/testdata/HEAD/core.v1.PersistentVolume.pb
diff --git a/testdata/HEAD/core.v1.PersistentVolume.yaml b/testdata/HEAD/core.v1.PersistentVolume.yaml
@@ -232,6 +232,7 @@ spec:
     storagePolicyName: storagePolicyNameValue
     volumePath: volumePathValue
 status:
+  lastPhaseTransitionTime: "2004-01-01T01:01:01Z"
   message: messageValue
   phase: phaseValue
   reason: reasonValue