Skip to content

Commit

Permalink
Merge pull request #126940 from pohly/dra-1.31-api-comments
Browse files Browse the repository at this point in the history
DRA API: update some comments

Kubernetes-commit: 2ecff6d0db8ccd65f3c34da054a917afd4a8e8d7
  • Loading branch information
k8s-publishing-bot committed Aug 31, 2024
2 parents 2ab66df + 56b18fa commit 2ed5b3f
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions resource/v1alpha3/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,12 @@ type DeviceClaim struct {
// +optional
// +listType=atomic
Config []DeviceClaimConfiguration `json:"config,omitempty" protobuf:"bytes,3,opt,name=config"`

// Potential future extension, ignored by older schedulers. This is
// fine because scoring allows users to define a preference, without
// making it a hard requirement.
//
// Score *SomeScoringStruct
}

const (
Expand Down Expand Up @@ -558,6 +564,16 @@ type DeviceConstraint struct {
// +optional
// +oneOf=ConstraintType
MatchAttribute *FullyQualifiedName `json:"matchAttribute,omitempty" protobuf:"bytes,2,opt,name=matchAttribute"`

// Potential future extension, not part of the current design:
// A CEL expression which compares different devices and returns
// true if they match.
//
// Because it would be part of a one-of, old schedulers will not
// accidentally ignore this additional, for them unknown match
// criteria.
//
// MatchExpression string
}

// DeviceClaimConfiguration is used for configuration parameters in DeviceClaim.
Expand Down

0 comments on commit 2ed5b3f

Please sign in to comment.