Skip to content

Commit

Permalink
Merge pull request #6755 from towca/jtuznik/provreq-disable
Browse files Browse the repository at this point in the history
Remove the flag for enabling ProvisioningRequests from CA 1.30
  • Loading branch information
k8s-ci-robot authored Apr 24, 2024
2 parents 6e3217d + f652e25 commit 2c2660a
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions cluster-autoscaler/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,9 @@ var (
"--max-graceful-termination-sec flag should not be set when this flag is set. Not setting this flag will use unordered evictor by default."+
"Priority evictor reuses the concepts of drain logic in kubelet(https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2712-pod-priority-based-graceful-node-shutdown#migration-from-the-node-graceful-shutdown-feature)."+
"Eg. flag usage: '10000:20,1000:100,0:60'")
provisioningRequestsEnabled = flag.Bool("enable-provisioning-requests", false, "Whether the clusterautoscaler will be handling the ProvisioningRequest CRs.")
frequentLoopsEnabled = flag.Bool("frequent-loops-enabled", false, "Whether clusterautoscaler triggers new iterations more frequently when it's needed")
// Intentionally disabled for the 1.30 Cluster Autoscaler release, since the ProvisioningRequest API is not stable yet.
// provisioningRequestsEnabled = flag.Bool("enable-provisioning-requests", false, "Whether the clusterautoscaler will be handling the ProvisioningRequest CRs.")
frequentLoopsEnabled = flag.Bool("frequent-loops-enabled", false, "Whether clusterautoscaler triggers new iterations more frequently when it's needed")
)

func isFlagPassed(name string) bool {
Expand Down Expand Up @@ -432,7 +433,8 @@ func createAutoscalingOptions() config.AutoscalingOptions {
},
DynamicNodeDeleteDelayAfterTaintEnabled: *dynamicNodeDeleteDelayAfterTaintEnabled,
BypassedSchedulers: scheduler_util.GetBypassedSchedulersMap(*bypassedSchedulers),
ProvisioningRequestEnabled: *provisioningRequestsEnabled,
// Intentionally disabled for the 1.30 Cluster Autoscaler release, since the ProvisioningRequest API is not stable yet.
ProvisioningRequestEnabled: false,
}
}

Expand Down

0 comments on commit 2c2660a

Please sign in to comment.