-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question: is it possible to run cluster-autoscaler in dry-run mode #1377
Comments
There's no support for this right now, and I don't think it'd be trivial change. Current logic assumes all requests for modifying cluster state are processed, so just injecting a version of cloud provider code which does nothing won't work out of the box for this - CA will enter back-offs, report node groups as unhealthy etc. You'd have to ensure all relevant parts of the logic are disabled, not just the calls to cloud provider. Additionally, its usefulness would be limited as it can only provide a single decision at any point in time. Let's say there are 3 nodes, each of utilized at 30% and otherwise removable. We know 2 of those can be safely removed, resulting in the third being 90% utilized. However, Cluster Autoscaler:
So the output of dry run would probably be sth like this, in random order:
But this doesn't mean all 3 nodes would be deleted if it was enabled. Without dry run, after removing the first node, one or both of the others may become unremovable. A second node may then be removed, but the last one won't. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, Its more of a question if we can run cluster-autoscaler in dry-run mode. We want to evaluate when autoscaler would have triggered the scale-down/up actions without actually taking the action (to avoid disruption during the evaluation)
Thanks
Rajat Jindal
The text was updated successfully, but these errors were encountered: