Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ephemeral storage requests recommendation and update to vpa #1751

Closed
mfilotto opened this issue Mar 5, 2019 · 9 comments
Closed

Add ephemeral storage requests recommendation and update to vpa #1751

mfilotto opened this issue Mar 5, 2019 · 9 comments
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mfilotto
Copy link

mfilotto commented Mar 5, 2019

It would be nice if vpa could also take care of ephemeral storage usage and set request accordinngly

@bskiba
Copy link
Member

bskiba commented Mar 6, 2019

@kgolab I think you were looking into this. Are there usage metrics for ephemeral storage available form Metric Server?

@bskiba bskiba added area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature. labels Mar 6, 2019
@kgolab
Copy link
Collaborator

kgolab commented Mar 8, 2019

@bskiba , at the moment Metric Server only serves metrics for CPU & memory usage.
But, since:

  • the ephemeral storage usage is also available via Kubelet summary API, scraped by Metric Server to obtain all the information,
  • and ephemeral storage is part of Pod resource request,
  • and it's been also mentioned in comments to in-place update KEP proposal,

maybe we could make a case for it being included in Metric Server and then supported by VPA.

@mfilotto , do you already have a use case in mind or, even better, described somewhere? We'd like to understand more about intended usage of these recommendations.
In particular I'm very interested in when would the recommendations be applicable from your perspective.

@mfilotto
Copy link
Author

mfilotto commented Mar 9, 2019

@kgolab I use vpa to set requests automatically. This way kubelets and scheduler will have a more precise intel of what's going on on each node. So my goal is to reduce evictions as much as possible. vpa do the job for memory and cpu but ephemeral storage are left unset so kubelet keep triggering evictions.
If vpa could also set ephemeral storage it would be awesome, this way vpa would help to reduce all evictions and be precious for capacity planning.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2019
@kgolab
Copy link
Collaborator

kgolab commented Jun 10, 2019

/remove-lifecycle stale
Marking as not to disappear from the radar, this might be revisited at some point.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 8, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 8, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this issue Feb 22, 2024
Signed-off-by: B1F030 <b1fzhang@gmail.com>
Co-authored-by: kerthcet <kerthcet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants