-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VPA] Request to support spec.selector in VPA #6493
Comments
In the beginning, VPA allowed for specifying the
I think not exposing |
Thank you for your detailed explanation. |
I'm closing this for now. If we find new, compelling use-cases which would need a manual selector definition, we can re-visit our reasoning. |
@voelzmo: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @voelzmo, for |
Which component are you using?:
Vertical Pod Autoscaler
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
VPA has only
spec.targetRef
, it supports controllers likeDeployment
,StatefulSet
and so on. However, VPA can't handle orphan pods(whose metadata.ownerReferences is empty). Orphan pods may happen in some scenarios, for example, some system use orphan pods to run stateful applications, and the orphan pods are controlled by some external system; pods controlled by a CR without scale resource, these pods can be regarded as orphan pods actually.Besides, internally VPA recommender uses labels selector that determines which Pods are controlled by a VPA object.
Describe the solution you'd like.:
Add an optional field in VPA spec,
spec.selector
. Users can define VPA withtargetRef
, alternatively defineselector
to select a group of pods.Describe any alternative solutions you've considered.:
Additional context.:
The text was updated successfully, but these errors were encountered: