Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pprof for vpa-admission-controller #6946

Open
huizhifan opened this issue Jun 19, 2024 · 8 comments
Open

pprof for vpa-admission-controller #6946

huizhifan opened this issue Jun 19, 2024 · 8 comments
Assignees
Labels
area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@huizhifan
Copy link

Which component are you using?:
vertical-pod-autoscaler

vpa-admission-controller
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

In our cluster, there are 3k pods and 100-200 vpa objects with Off updateMode. Theoretically, the vpa-admission-controller is supposed to have little work load. But the memory usage goes up to 1000Mi. We want to learn why this amount of memory is consue
Describe the solution you'd like.:

Enable pprof in vpa-admission-controller
Describe any alternative solutions you've considered.:

Additional context.:

@huizhifan huizhifan added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 19, 2024
@adrianmoisey
Copy link
Contributor

/area vertical-pod-autoscaler

@voelzmo
Copy link
Contributor

voelzmo commented Jul 15, 2024

/triage accepted
/label good-first-issue

This is very relevant to issues we've seen before like #6368

@k8s-ci-robot
Copy link
Contributor

@voelzmo: The label(s) `/label good-first-issue

cannot be applied. These labels are supported:api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?

In response to this:

/triage accepted
/label good-first-issue

This is very relevant to issues we've seen before like #6368

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 15, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Jul 15, 2024

/label good first issue

@voelzmo
Copy link
Contributor

voelzmo commented Jul 15, 2024

/label "good first issue"

@voelzmo
Copy link
Contributor

voelzmo commented Jul 15, 2024

/assign @adrianmoisey

@raywainman
Copy link
Contributor

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@raywainman:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants