Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA: Remove the vendor dir #7570

Closed
ialidzhikov opened this issue Dec 5, 2024 · 6 comments · Fixed by #7573 or #7572
Closed

VPA: Remove the vendor dir #7570

ialidzhikov opened this issue Dec 5, 2024 · 6 comments · Fixed by #7573 or #7572
Labels
area/vertical-pod-autoscaler kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@ialidzhikov
Copy link
Contributor

Which component are you using?:
/area vertical-pod-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
Remove the vendor dir for dev-productivity purposes. Right now, on updating dependencies the GitHub web app crashes. The vendor dir also causes delays while cloning the rep and while resolving conflicts (you get unnecessary conflicts under the vendor dir).

Describe the solution you'd like.:

Remove the vendor dir for the VPA. The cluster-autoscaler no longer has a vendor dir. It seems to be removed with #6973.

Describe any alternative solutions you've considered.:
N/A

Additional context.:

See #7551 (comment)

@ialidzhikov ialidzhikov added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 5, 2024
@adrianmoisey
Copy link
Member

/remove-kind feature
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 5, 2024
@adrianmoisey
Copy link
Member

/assign davidspek

@k8s-ci-robot
Copy link
Contributor

@adrianmoisey: GitHub didn't allow me to assign the following users: davidspek.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign davidspek

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adrianmoisey
Copy link
Member

/open

Still waiting on #7572

@adrianmoisey
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@adrianmoisey: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
3 participants