Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Resizer - Handling decoding error #3833

Conversation

krzysied
Copy link
Contributor

Node calculation should fail when there is a problem with decoding metrics. Addon Resizer will retry querying metrics after a few second (main loop).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2021
@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysied, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 55fe06d into kubernetes:addon-resizer-release-1.8 Jan 20, 2021
@ravilr
Copy link

ravilr commented Apr 23, 2021

@bskiba @wojtek-t looks like the https://github.com/kubernetes/autoscaler/releases/tag/addon-resizer-1.8.12 doesn't seem to have the docker image promoted to production gcr.io repo https://console.cloud.google.com/gcr/images/k8s-artifacts-prod
Can you please help with publishing k8s.gcr.io/addon-resizer:1.8.12 docker image?

@bskiba
Copy link
Member

bskiba commented Apr 26, 2021

Thanks for bringing this up, should be fixed once kubernetes/k8s.io#1969 merges.

@ravilr
Copy link

ravilr commented Apr 27, 2021

Thanks. addon-resizer 1.8.12 image is now available at k8s.gcr.io/autoscaling/addon-resizer:1.8.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants